Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): Avoid importing SentryWebpackPlugin in dev mode #8557

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Jul 17, 2023

This fix was already reviewed, merged and released in the last beta. This PR will now merge it into develop to make it available with the next official release. Thanks to the users who tested the beta released and confirmed that it is working.


As reported in #8541, our NextJS SDK currently breaks dev mode for the newest NextJS 13.4.10 version

I still have absolutely no idea which of the changes in
13.4.10 is causing this.
However, I traced the error back and it happens as soon as our NextJS SDK package requires @sentry/webpack-plugin:

  • @sentry/nextjs calls require('@sentry/webpack-plugin')
  • @sentry/webpack-plugin calls const { RawSource } = require('webpack-sources');
  • For whatever reason, NextJS can't require webpack-sources and throws 💥

Since we don't enable our Webpack plugin in dev
mode
anyway, one way to get rid of this error is to only require it if we're not in dev mode.

This hotfix therefore moves the top-level require of @sentry/webpack-plugin to a dynamic require. This isn't a great solution and honestly quite ugly but if it unblocks users for now I'd say we merge it. I think we should definitely revisit this though once we know more about why NextJS suddenly isn't able to import webpack-sources.

cc @lforst once you're back, maybe we can revisit this together.

closes #8541

As reported in #8541, our NextJS SDK currently breaks dev mode for the
newest NextJS 13.4.10 version

I have absolutely no idea which of the changes in
[13.4.10](https://github.com/vercel/next.js/releases/tag/v13.4.10) is
causing this.
However, I traced the error back and it happens as soon as our NextJS
SDK package requires @sentry/webpack-plugin:

* @sentry/nextjs calls `require('@sentry/webpack-plugin')`
* @sentry/webpack-plugin calls `const { RawSource } =
require('webpack-sources');`
* For _whatever_ reason, NextJS can't require `webpack-sources` and
throws 💥

Since we don't enable our Webpack plugin [in dev
mode](https://github.com/getsentry/sentry-javascript/blob/723f851f358b75cd39da353804c51ff27ebb0c11/packages/nextjs/src/config/webpack.ts#L305)
anyway, one way to get rid of this error is to only require it if we're
_not_ in dev mode.

This hotfix therefore moves the top-level require of
`@sentry/webpack-plugin` to a dynamic require. This isn't a great
solution and honestly quite ugly but if it unblocks users for now I'd
say we merge it. I think we should definitely revisit this though once
we know more about why NextJS suddenly isn't able to import
`webpack-sources`.

ref #8541
@Lms24 Lms24 requested a review from AbhiPrasad July 17, 2023 15:28
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 21.95 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 69.13 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 20.29 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 60.38 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.9 KB (0%)
@sentry/browser - Webpack (minified) 71.51 KB (0%)
@sentry/react - Webpack (gzipped + minified) 21.92 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 50.58 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 30.11 KB (0%)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 28.16 KB (0%)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 49.44 KB (+0.04% 🔺)
@sentry/replay - Webpack (gzipped + minified) 43.16 KB (+0.15% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 69.52 KB (+0.02% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 61.83 KB (+0.03% 🔺)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants